This repository has been archived by the owner on Sep 13, 2018. It is now read-only.
Update example code to use tokio-io crate #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling the demo no longer complains about a dozen things being deprecated and should be a little more future-proof. Changes are mostly identical to the example at https://tokio.rs/docs/getting-started/simple-server/. The server now also handles CRLF line endings, so it can be used with telnet.
carllerche
suggested changes
Apr 26, 2017
src/lib.rs
Outdated
| //! fn encode(&mut self, item: u64, into: &mut Vec<u8>) -> io::Result<()> { | ||
| //! writeln!(into, "{}", item); | ||
| //! fn encode(&mut self, item: u64, into: &mut BytesMut) -> io::Result<()> { | ||
| //! writeln!(into.writer(), "{}", item)?; |
There was a problem hiding this comment.
into needs to reserve OR you can use into.extend(...). Otherwise, you could hit a panic trying to write data into the BytesMut when there isn't enough capacity.
Otherwise if there's insufficient capacity it apparently could panic
|
The comments and texts should probably also be updated here. Currently |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling the demo no longer complains about a dozen things being
deprecated and should be a little more future-proof. Changes are mostly
identical to an example on tokio.rs.
The server now also handles CRLF line endings, so it can be used with
telnet.