Add support for bincode #130
Draft
+120
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary test Update bincode version specifier Adjust comments
Darksonn
reviewed
Feb 11, 2023
Comment on lines
27
to
+29
| [dependencies] | ||
| serde = { version = "1.0.95", optional = true, default-features = false, features = ["alloc"] } | ||
| bincode = { version = "2.0.0-rc", optional = true, default-features = false } |
There was a problem hiding this comment.
We're not going to add a release candidate as a dependency. Upgrading to the real 2.0.0 when it is released would be a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bincodeis a compact format that doesn't store field names. When storing aSlabcontaining lots of entries with many fields and small values, the output frombincodecan be significantly smaller compared toserdeformats like JSON and CBOR.Even though
bincodealready providesserdefeature that works with all types implementingserde's traits, it has limitations, and comes with a roughly 20% performance decrease based on my local testing.