-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump msrv to 1.70 #975
Conversation
Can you give more context why you think this is needed? For me,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking further into it, my previous command didn't account for the other projects in the workspace. The correct command to reproduce this problem is:
$ cargo +1.60 check --workspace --all-features
error: package `indexmap v2.2.2` cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.60.0
@@ -12,7 +12,7 @@ documentation = "https://docs.rs/prost-build" | |||
readme = "README.md" | |||
description = "A Protocol Buffers implementation for the Rust Language." | |||
edition = "2021" | |||
rust-version = "1.60" | |||
rust-version = "1.70" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are actually more than one rust-version
definitions in the code base. Can you update the others as well?
This PR can be closed as the issue is fixed in #982 |
Are there any reason to bump the msrv of the crates which do not depend on |
It feels like there is too little maintainer capacity, and I think a single MSRV for the whole repo is easier to maintain. This PR doesn't actually verify the MSRV of main |
Yes, and it has not been performed in this project as well so far. Bumping the |
Let's continue this discussion in #983 |
home
0.5.9 requires Rust 1.70.