-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Debug impl optional for types #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a fine approach, I would like to see a lot of tests added around the different combinations of debug impls and to also make sure the root level debug isn't a problem.
Friendly bump on this @audunska -- would you be able to add some tests? This would be a really useful feature. |
I didn't end up prioritizing it, but I can do it now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a nice addition but I think we should add some tests since there is a lot of changes to the codegen.
71174c6
to
49f83e6
Compare
49f83e6
to
6f5007e
Compare
5737b0c
to
62596f3
Compare
Ok, I've added some tests testing both the Message trait directly, and testing code generation. Anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests!
See #795 for motivation. If this looks like an ok approach, I'll go ahead and add more documentation.
Where is a good place to put some tests for this behavior?