chore: Move prost to a subdirectory
#1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibbz00
force-pushed
the
workspace_separation
branch
from
84b90ff
to
1a5e99f
Compare
gibbz00
force-pushed
the
workspace_separation
branch
from
1a5e99f
to
2dce334
Compare
Removes the need to always specify append `--workspace` in the common cargo commands. `rust-analyser` seems to get confused and locks the workspace longer than needed under the previous structure. (Lots of `Blocking waiting for file lock on build directory` waiting.) Unable to find an issue mentioning this. Goals it to then make repo to more easily managed. Examples: * Consolidate crate package metadata, dependency versions and clippy lints in the workspace `Cargo.toml` * Placing all crates in a `crates/` for automatic workspace member inclucion.
gibbz00
force-pushed
the
workspace_separation
branch
from
2dce334
to
e20c115
Compare
caspermeijn
approved these changes
Apr 22, 2024
caspermeijn
changed the title
Cargo.toml workspace and crate declarationprost to a subdirectory
caspermeijn
added a commit
to caspermeijn/prost
that referenced
this pull request
May 10, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033. fixes tokio-rs#1054
caspermeijn
added a commit
to caspermeijn/prost
that referenced
this pull request
May 17, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033. fixes tokio-rs#1054
caspermeijn
added a commit
to caspermeijn/prost
that referenced
this pull request
May 20, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033. fixes tokio-rs#1054
caspermeijn
added a commit
to caspermeijn/prost
that referenced
this pull request
May 21, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033. fixes tokio-rs#1054
caspermeijn
added a commit
to caspermeijn/prost
that referenced
this pull request
May 23, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033. fixes tokio-rs#1054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need to always specify append
--workspacein the common cargo commands.rust-analyserseems to get confused and locks the workspace longer than needed under the previous structure. (Lots ofBlocking waiting for file lock on build directorywaiting.) Unable to find an issue mentioning this.Goals it to then make repo to more easily managed. Examples:
Consolidate crate package metadata, dependency versions and clippy lints in the workspace
Cargo.tomlPlacing all crates in a
crates/for automatic workspace member inclucion.