-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prost-build: Split Config
into a separate module and file.
#1015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibbz00
force-pushed
the
modules_splitting_1
branch
from
March 29, 2024 16:23
eff0156
to
0affa1b
Compare
fixes `noop_method_call` clippy lint warning.
* Makes that the entrire workspace is checked, but tests too.
gibbz00
force-pushed
the
modules_splitting_1
branch
2 times, most recently
from
April 6, 2024 08:01
8d89499
to
136d970
Compare
I already commented on the config split in #1020. I suggest doing the config and module split as two commits in a single PR. |
Oki, I think I'll just close both and redo this in a new PR. Think it will be easier to resolve new conflicts that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See note about possibly changing the visibility of some helper methods to private
. Leaving this as a draft until it is resolved😊prost/prost-build/src/lib.rs
Lines 150 to 153 in eff0156
Depends on #1008.