Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prost-build: Split Config into a separate module and file. #1015

Closed
wants to merge 12 commits into from

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Mar 29, 2024

See note about possibly changing the visibility of some helper methods to private . Leaving this as a draft until it is resolved 😊

// HELP(gibbz00): I think `error_message_protoc_not_found`, `protoc_from_env`, and `protoc_include_from_env`
// should be made private. Only used inside config and not in any other part
// of prost. Leaving this as is for now as this would technically be breaking
// changes.

Depends on #1008.

@gibbz00 gibbz00 force-pushed the modules_splitting_1 branch 2 times, most recently from 8d89499 to 136d970 Compare April 6, 2024 08:01
@gibbz00 gibbz00 marked this pull request as ready for review April 6, 2024 08:02
@caspermeijn
Copy link
Collaborator

I already commented on the config split in #1020. I suggest doing the config and module split as two commits in a single PR.

@gibbz00
Copy link
Contributor Author

gibbz00 commented Apr 13, 2024

Oki, I think I'll just close both and redo this in a new PR. Think it will be easier to resolve new conflicts that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants