Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Document feature flags #1003

Merged
merged 1 commit into from
Apr 2, 2024
Merged

docs: Document feature flags #1003

merged 1 commit into from
Apr 2, 2024

Conversation

caspermeijn
Copy link
Collaborator

Open question:

  • What is the function of prost-derive feature?

@caspermeijn caspermeijn marked this pull request as draft March 15, 2024 14:40
@caspermeijn caspermeijn force-pushed the document_features branch 2 times, most recently from eda7369 to e057811 Compare March 29, 2024 07:41
@caspermeijn caspermeijn marked this pull request as ready for review March 29, 2024 07:42
@caspermeijn caspermeijn changed the title WIP: docs: Document feature flags docs: Document feature flags Mar 29, 2024
@caspermeijn caspermeijn requested a review from LucioFranco March 29, 2024 07:42
gibbz00
gibbz00 reviewed Mar 29, 2024
View reviewed changes
prost-build/src/lib.rs Outdated
@@ -125,6 +125,10 @@
//! // Now compile your proto files via prost-build
//! ```
//!
//! ## Feature Flags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details about some of these features are currently placed before this. Perhaps place this first and reference the respective details sections?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I moved the Feature Flags section

@LucioFranco LucioFranco added this pull request to the merge queue Apr 2, 2024
Merged via the queue into tokio-rs:master with commit b3de938 Apr 2, 2024
12 checks passed
@caspermeijn caspermeijn deleted the document_features branch April 5, 2024 06:43
gibbz00 pushed a commit to gibbz00/prost that referenced this pull request Apr 6, 2024
@caspermeijn @gibbz00
docs: Document feature flags (tokio-rs#1003)
85ba42a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibbz00 gibbz00 gibbz00 left review comments

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caspermeijn @LucioFranco @gibbz00