Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add must_use to Interest methods #1694

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Add must_use to Interest methods #1694

merged 1 commit into from
Jul 25, 2023

Conversation

Darksonn
Copy link
Contributor

I saw someone use the Interest::remove method as-if it modified the thing it was called on. Add #[must_use] to add and remove to prevent this kind of mistake.

@Thomasdezeeuw Thomasdezeeuw merged commit 48f0159 into master Jul 25, 2023
@Thomasdezeeuw
Copy link
Collaborator

Thanks @Darksonn

@Thomasdezeeuw Thomasdezeeuw deleted the alice/interest-must-use branch July 25, 2023 11:19
@Darksonn Darksonn mentioned this pull request Sep 10, 2023
Merged
@nylonicious nylonicious mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darksonn @Thomasdezeeuw