Skip to content

Commit

Permalink
[illumos] switch waker impl back to being pipe-based
Browse files Browse the repository at this point in the history
In
1133ed0,
it looks like the waker implementation on illumos (perhaps inadvertently) got
switched from being pipe-based to being eventfd-based. Unfortunately, the
eventfd impl seems to break the `waker_multiple_wakeups_different_thread` on illumos:

```
thread 'waker_multiple_wakeups_different_thread' panicked at tests/waker.rs:157:5:
assertion failed: !events.is_empty()
```

While we separately figure out what might be going wrong in the eventfd impl,
it's worth switching back to the old pipe-based impl which is known to work,
and which does fix this test.
  • Loading branch information
sunshowers committed Aug 7, 2024
1 parent 4a5114e commit c2a8968
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/sys/unix/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ cfg_os_poll! {
target_os = "espidf",
target_os = "fuchsia",
target_os = "hermit",
target_os = "illumos",
target_os = "linux",
)
), path = "waker/eventfd.rs")]
Expand Down Expand Up @@ -94,6 +93,7 @@ cfg_os_poll! {
target_os = "dragonfly",
target_os = "haiku",
target_os = "hurd",
target_os = "illumos",
target_os = "netbsd",
target_os = "nto",
target_os = "openbsd",
Expand Down Expand Up @@ -146,6 +146,7 @@ cfg_os_poll! {
target_os = "openbsd",
target_os = "redox",
target_os = "solaris",
target_os = "illumos",
target_os = "vita",
),
// Hermit doesn't support pipes.
Expand Down

0 comments on commit c2a8968

Please sign in to comment.