Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check minimal versions on CI #596

Merged
merged 1 commit into from
Nov 12, 2024
Merged

chore: check minimal versions on CI #596

merged 1 commit into from
Nov 12, 2024

Commits on Nov 5, 2024

  1. chore: check minimal versions on CI

    As reported in issue #592, in our release of `console-api` 0.8.1, we
    specified that we required a tonic version of 0.12 in teh Cargo.toml
    file. However, since we had generated Rust code with `tonic-build`
    0.12.3, we had some code that was only present in `tonic` from 0.12.3
    as well.
    
    This error was fixed in #593.
    
    However, this showed a gap in our CI testing, we don't test against
    minimum versions of our dependencies to catch this kind of error.
    
    This change adds a CI job to check the minimal versions of our direct
    dependencies. We perform a cargo update with the `-Z
    direct-minimal-versions` flag and then perform cargo check. This would
    have caught the previous error and will catch any new ones of a similar
    type.
    
    One downside to this approach is that we must explicitly give a minimum
    version for our direct dependencies that is equal to or greater than the
    minimum version that any of of transitive dependencies specify for that
    same crate. However this check is probably worth the annoyance.
    hds committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    341c02b View commit details
    Browse the repository at this point in the history