Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update repository README screenshots and help text #422

Merged
merged 1 commit into from
May 12, 2023
Merged

doc: update repository README screenshots and help text #422

merged 1 commit into from
May 12, 2023

Conversation

hds
Copy link
Collaborator

@hds hds commented May 12, 2023

In #421, the screenshots in the tokio-console README were updated to
match the current code. The contents of the README also go into the
docs.rs page.

This change updates the two screenshots in the README in the root of the
repository. They now match the UI shown by the current code at the
latest release of tokio-console, 0.1.8. The screenshots are a little
bit wider than the ones in the tokio-console README as the example
app from the console-subscriber crate was used as the instrumented
application and the source file paths are longer.

The screenhots are now using relative links directly to the files in the
repository.

Additionally, the help text in the main README has been updated to
reflect what tokio-console now produces. This includes additional
descriptive text and also mentions how to connect to a Unix domain
socket.

In #421, the screenshots in the `tokio-console` README were updated to
match the current code. The contents of the README also go into the
docs.rs page.

This change updates the two screenshots in the README in the root of the
repository. They now match the UI shown by the current code at the
latest release of `tokio-console`, 0.1.8. The screenshots are a little
bit wider than the ones in the `tokio-console` README as the example
`app` from the `console-subscriber` crate was used as the instrumented
application and the source file paths are longer.

The screenhots are now using relative links directly to the files in the
repository.

Additionally, the help text in the main README has been updated to
reflect what `tokio-console` now produces. This includes additional
descriptive text and also mentions how to connect to a Unix domain
socket.
@hds hds requested a review from a team as a code owner May 12, 2023 14:02
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, thank you!

@hawkw hawkw merged commit cbf6f56 into tokio-rs:main May 12, 2023
hawkw pushed a commit that referenced this pull request Sep 29, 2023
In #421, the screenshots in the `tokio-console` README were updated to
match the current code. The contents of the README also go into the
docs.rs page.

This change updates the two screenshots in the README in the root of the
repository. They now match the UI shown by the current code at the
latest release of `tokio-console`, 0.1.8. The screenshots are a little
bit wider than the ones in the `tokio-console` README as the example
`app` from the `console-subscriber` crate was used as the instrumented
application and the source file paths are longer.

The screenhots are now using relative links directly to the files in the
repository.

Additionally, the help text in the main README has been updated to
reflect what `tokio-console` now produces. This includes additional
descriptive text and also mentions how to connect to a Unix domain
socket.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants