feat(console-api): Update tonic to 0.7
#318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates `tonic` and `prost` to their latest versions. In addition this PR changes how the generated protobuf is built from being done in a `build.rs` file to a `tests/boostrap.rs` test. This removes the need for downstream consumers to compile/provide `protoc` for `prost` to generate the protobuf files (which was changed in `0.10`). The bootstrap test will first attempt to compile the protobuf files and check if there is a git diff between the checked in version. If there is a difference it will fail the test waiting for the files to be checked in. This will fail PRs that have updated the protobuf files but not checked in the new versions.
LucioFranco
changed the title
tonic to 0.7tonic to 0.7
|
I tried adding some code to download protoc to speed up CI but didn't realize that deps were cached so we only pay the cost on the first build. Going to back out my changes. |
LucioFranco
force-pushed
the
lucio/update-tonic
branch
from
4036c5b to
606cf72
Compare
LucioFranco
commented
Apr 2, 2022
Comment on lines
+28
to
+30
| # Make 1.58 MSRV due to <=1.57 failing to build console-api due to a bug | ||
| # with cargo version resolution. | ||
| minrust: 1.58.0 |
There was a problem hiding this comment.
Would be good to find the bug here 🤷
hawkw
reviewed
Apr 7, 2022
|
So |
hawkw
changed the title
tonic to 0.7tonic to 0.7
hawkw
added a commit
that referenced
this pull request
Apr 8, 2022
hawkw
added a commit
that referenced
this pull request
Apr 11, 2022
hawkw
added a commit
that referenced
this pull request
Apr 11, 2022
<a name="0.1.4"></a> ## 0.1.4 (2022-04-11) #### Bug Fixes * fix memory leak from historical `PollOp`s (#311) ([9178ecf](9178ecf), closes [#256](256)) #### Features * **console-api:** Update `tonic` to `0.7` (#318) ([83d8a87](83d8a87)) * don't trace tasks spawned through the console server (#314) ([0045e9b](0045e9b))
hawkw
pushed a commit
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
tonicandprostto their latest versions. Inaddition this PR changes how the generated protobuf is built from being
done in a
build.rsfile to atests/boostrap.rstest. This removesthe need for downstream consumers to compile/provide
protocforprostto generate the protobuf files (which was changed in0.10).The bootstrap test will first attempt to compile the protobuf files and
check if there is a git diff between the checked in version. If there is
a difference it will fail the test waiting for the files to be checked
in. This will fail PRs that have updated the protobuf files but not
checked in the new versions.
BREAKING CHANGE:
console-apiis now no longer compatible with projects usingprost0.9 or
tonic0.7. These crates must be updated to useconsole-api0.2.