Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: emit data about Waker events #42

Closed
seanmonstar opened this issue Jun 8, 2021 · 0 comments · Fixed by #44
Closed

subscriber: emit data about Waker events #42

seanmonstar opened this issue Jun 8, 2021 · 0 comments · Fixed by #44
Labels
S-feature Severity: feature. This is adding a new feature.

Comments

@seanmonstar
Copy link
Member

Next step after #37.

We want to detect a few things with regards to the Wakers related to a Task:

  • Time from wake to poll
  • If poll returns Pending but the Waker wasn't cloned.
    • While not fool proof, this could be a good-enough heuristic to detect a "forgot to wake".
  • If wake was called from a different thread, or same thread.
  • If a wake is called from within poll
    • While not wrong, could be a sign to help someone notice a task that "busy loops".
@seanmonstar seanmonstar added the S-feature Severity: feature. This is adding a new feature. label Jun 8, 2021
This was referenced Jun 8, 2021
@hawkw hawkw closed this as completed in #44 Jun 14, 2021
hawkw pushed a commit that referenced this issue Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-feature Severity: feature. This is adding a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant