Histogram empty with tokio-console 0.1.1
#262
Comments
|
The problem was introduced in 095b1ef |
benthillerkus
referenced
this issue
Jan 19, 2022
Currently, `console-subscriber` contains a bunch of machinery for rewriting non-sequential `span::Id`s from `tracing` to sequential IDs (see #75). Upon thinking about this for a bit, I don't actually understand why this has to be done on the instrumentation-side. This seems like extra work that's currently done in the instrumented application, when it really doesn't have to be. Instead, the client should be responsible for rewriting `tracing` IDs to pretty, sequential user-facing IDs. This would have a few advantages: - it moves some work out of the application, which is always good - if data is being emitted through an implementation other than `console-subscriber`, we will *still* get nicely ordered ids - this also makes some of the stuff i'm working on in #238 easier This branch removes ID rewriting from `console-subscriber`, and adds it to the `console` CLI's `state` module. Closes #240 Signed-off-by: Eliza Weisman <[email protected]>
|
Thanks for the report! I believe this is related to the issue fixed in #251, but it looks like --- for whatever reason --- that commit didn't fix this. I'll have to take a closer look. |
|
I don't think this is platform specific, I've managed to reproduce on M1 and Linux (Ubuntu). |
|
I agree that it's almost certainly not platform specific. |
hawkw
changed the title
tokio-console 0.1.1tokio-console 0.1.1
jtgeibel
added a commit
to jtgeibel/console
that referenced
this issue
Jan 28, 2022
Task `Details` are tracked by the remote's `span::Id` while the `Task::id()` is the friendly id. The comparison in the view is changed to use the remote span ids and the field in `Details` is renamed to match. Fixes: tokio-rs#262
Merged
|
I've opened #269 which should fix this. |
hawkw
pushed a commit
that referenced
this issue
Jan 28, 2022
Task `Details` are tracked by the remote's `span::Id` while the `Task::id()` is the friendly id. The comparison in the view is changed to use the remote span ids and the field in `Details` is renamed to match. Fixes: #262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Also note that the ID seems to be different, while the rest of the stats is the same.
Last working release
tokio-console 0.1.0Steps to reproduce
cargo install tokio-consoletokio-console -V->tokio-console 0.1.1git clone https://github.com/tokio-rs/consolecd console\console-subscriber\examplescargo run --example apptokio-consoleSystem Info
rustc -V->rustc 1.58.0 (02072b482 2022-01-11)Windows 10 21H2 build
19044.1466The text was updated successfully, but these errors were encountered: