fix(console): accept only file://, http://, https:// URI (#486)

Tokio console can connect to a console subscriber over HTTP or
(on UNIX) via a socket. However, no check was performed to
ensure that the server string matched the HTTP(S) or FILE protocols.
This was reported to lead to strange behavior (#401).

This change adds an explicit check on the URI scheme to ensure that
it is one of `http`, `https`, or `file`.

closes: #401

Signed-off-by: hi-rustin <[email protected]>

tokio-console/src/config.rs

@@ -363,11 +363,22 @@ impl Config {
         self.retain_for.unwrap_or_default().0
     }
 
-    pub(crate) fn target_addr(&self) -> Uri {
-        self.target_addr
+    pub(crate) fn target_addr(&self) -> color_eyre::Result<Uri> {
+        let target_addr = self
+            .target_addr
             .as_ref()
             .unwrap_or(&default_target_addr())
-            .clone()
+            .clone();
+        match target_addr.scheme_str() {
+            Some("file" | "http" | "https") => {}
+            _ => {
+                return Err(color_eyre::eyre::eyre!(
+                "invalid scheme for target address {:?}, must be one of 'file', 'http', or 'https'",
+                target_addr
+            ))
+            }
+        }
+        Ok(target_addr)
     }
 
     pub(crate) fn add_issue_metadata(

tokio-console/src/main.rs

@@ -53,7 +53,7 @@ async fn main() -> color_eyre::Result<()> {
         None => {}
     }
 
-    let target = args.target_addr();
+    let target = args.target_addr()?;
     tracing::info!(?target, "using target addr");
 
     let retain_for = args.retain_for();