Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize vtable api #558

Closed
wants to merge 1 commit into from
Closed

Stabilize vtable api #558

wants to merge 1 commit into from

Conversation

ipoupaille
Copy link

The use case is for example use Bytes create with memory from mmap.
A file is mapped in memory before construct of the first bytes, and unmapped when the last is dropped.

@ipoupaille ipoupaille mentioned this pull request Aug 27, 2022
@NobodyXu
Copy link
Contributor

NobodyXu commented Nov 1, 2022

IMHO marking the all fields of Vtable struct as pub might be a compatibility issue in the future.
What if we want to add a new optional function to Vtable?

I think it's better to have a VtableBuilder to build Vtable where new optional functions can be skipped.

@ipoupaille ipoupaille closed this by deleting the head repository Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants