Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export BodyDataStream from axum #2509

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Re-export BodyDataStream from axum #2509

merged 1 commit into from
Jan 11, 2024

Conversation

davidpdrsn
Copy link
Member

Happened to notice that BodyDataStream wasn't re-exported by axum. So you had to depend on axum-core to name that type.

@davidpdrsn davidpdrsn requested a review from jplatte January 11, 2024 20:25
@davidpdrsn davidpdrsn enabled auto-merge (squash) January 11, 2024 20:25
jplatte
jplatte approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this type in the docs, I noticed that the method that produces it (Body::into_data_stream) has broken intra-doc links to the Stream trait. Can be fixed in a separate PR of course.

@davidpdrsn davidpdrsn merged commit d3112a4 into main Jan 11, 2024
18 checks passed
@davidpdrsn davidpdrsn deleted the david/re-export-BodyDataStream branch January 11, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpdrsn @jplatte