fix: Exclude module AndroidPdfViewerV1 (#1351)

tokenstreet-tech · Jan 10, 2024 · 5363fce · 5363fce
1 parent fc3ea82
commit 5363fce
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 20 deletions.
diff --git a/examples/bare/android/app/src/main/AndroidManifest.xml b/examples/bare/android/app/src/main/AndroidManifest.xml
@@ -1,5 +1,13 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
+    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
     <uses-permission android:name="android.permission.INTERNET" />
+    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
+    <uses-permission android:name="android.permission.CAMERA" />
+    <uses-permission android:name="android.permission.FLASHLIGHT" />
+    <uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS" />
+    <uses-permission android:name="android.permission.RECORD_AUDIO" />
+    <uses-permission android:name="android.permission.BLUETOOTH" />
+    <uses-permission android:name="android.permission.BLUETOOTH_ADMIN" />
 
     <application
         android:name=".MainApplication"

diff --git a/examples/bare/android/build.gradle b/examples/bare/android/build.gradle
@@ -22,14 +22,6 @@ apply plugin: "com.facebook.react.rootproject"
 
 allprojects {
     repositories {
-        jcenter() {
-            // JCenter is now read-only. Therefore, no new versions are published there any more.
-            // We only fetch the necessary dependencies for IDnow from JCenter to avoid loading old dependencies.
-            content {
-                includeModule("me.relex", "circleindicator")
-                includeModule("com.github.barteksc", "android-pdf-viewer")
-            }
-        }
         maven() {
             url "https://raw.githubusercontent.com/idnow/de.idnow.android/master"
             content {

diff --git a/examples/bare/ios/Podfile.lock b/examples/bare/ios/Podfile.lock
@@ -1056,7 +1056,7 @@ PODS:
     - React-logger (= 0.73.1)
     - React-perflogger (= 0.73.1)
   - SocketRocket (0.6.1)
-  - tokenstreet-react-native-idnow-videoident (0.25.1):
+  - tokenstreet-react-native-idnow-videoident (0.26.0):
     - glog
     - IDnowSDK (= 7.4.1)
     - libPhoneNumber-iOS
@@ -1280,7 +1280,7 @@ SPEC CHECKSUMS:
   React-utils: debda2c206770ee2785bdebb7f16d8db9f18838a
   ReactCommon: ddb128564dcbfa0287d3d1a2d10f8c7457c971f6
   SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
-  tokenstreet-react-native-idnow-videoident: ed49c1856e80609df49bcf533197c4c7d8dd81d5
+  tokenstreet-react-native-idnow-videoident: b32444d230875c1f0e24be12326ee98fa07cc563
   Yoga: 4f53dc50008d626fa679c7a1cb4bed898f8c0bde
 
 PODFILE CHECKSUM: cea7d3c98434dcd2e2833a3fcccd6bfb5e99ae7d

diff --git a/examples/expo/app.json b/examples/expo/app.json
@@ -38,7 +38,17 @@
                     }
                 }
             ],
-            ["expo-build-properties", { "android": { "minSdkVersion": 23 } }]
+            [
+                "expo-build-properties",
+                {
+                    "android": {
+                        "buildToolsVersion": "34.0.0",
+                        "minSdkVersion": 23,
+                        "compileSdkVersion": 34,
+                        "targetSdkVersion": 34
+                    }
+                }
+            ]
         ]
     }
 }
diff --git a/src/expo/withAndroidIdnowVideoIdentSdk.ts b/src/expo/withAndroidIdnowVideoIdentSdk.ts
@@ -7,14 +7,6 @@ import { getConfigPluginTag } from './util/getConfigPluginTag';
 
 const repositoriesRegex = /maven(?:\s+)?\{(?:\s+)?url(?:\s+)?'https:\/\/www.jitpack.io'(?:\s+)?\}/u;
 const repositoriesCode =
-    '        jcenter() {\n' +
-    '            // JCenter is now read-only. Therefore, no new versions are published there any more.\n' +
-    '            // We only fetch the necessary dependencies for IDnow from JCenter to avoid loading old dependencies.\n' +
-    '            content {\n' +
-    '                includeModule("me.relex", "circleindicator")\n' +
-    '                includeModule("com.github.barteksc", "android-pdf-viewer")\n' +
-    '            }\n' +
-    '        }\n' +
     '        maven() {\n' +
     '            url "https://raw.githubusercontent.com/idnow/de.idnow.android/master"\n' +
     '            content {\n' +
@@ -29,7 +21,7 @@ const excludeDuplicateClassesCode =
     '        all*.exclude module: "bcprov-jdk15to18"\n' +
     '        all*.exclude module: "bcutil-jdk15to18"\n' +
     '        all*.exclude module: "pdfium-android"\n' +
-    '        all*.exclude module: "android-pdf-viewer"\n' +
+    '        all*.exclude module: "AndroidPdfViewerV1"\n' +
     '    }';
 
 /**