Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all integration tests refactored #331

Merged
merged 2 commits into from
Nov 18, 2024
Merged

all integration tests refactored #331

merged 2 commits into from
Nov 18, 2024

Conversation

florin01hyma
Copy link
Contributor

I addressed issue #329
I refactored the entirety of the integration tests to get a better readability in the terminal when a test fails, displaying the expected and actual outputs.
An excerpt function has been created to handle the token trimming.

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 25b1546

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@jorenbroekema jorenbroekema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took a while, just 2 notes

test/integration/color-modifier-references.test.ts Outdated Show resolved Hide resolved
test/integration/utils.ts Outdated Show resolved Hide resolved
@jorenbroekema jorenbroekema merged commit d66998b into main Nov 18, 2024
2 checks passed
@jorenbroekema jorenbroekema deleted the tests-refactor branch November 18, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants