Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ExpandTypesMap composition letterSpacing should remain letterSpacing #316

Closed
jorenbroekema opened this issue Sep 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jorenbroekema
Copy link
Member

What happened?

https://github.com/tokens-studio/sd-transforms/blob/main/src/index.ts#L51 should be the same as https://github.com/tokens-studio/sd-transforms/blob/main/src/index.ts#L43 (so we can just remove it L51)

This ensures that for composition tokens, letterSpacing props are going to be of type letterSpacing, and not dimension. This way, the sd-transforms letterspacing transform can apply to them.

Reproduction

Cannot repro in configurator because it does not support JS config and the expand types map needs to be imported first..

Expected output

No response

Version

1.2.4

@jorenbroekema jorenbroekema added bug Something isn't working triage To be reproduced as bug labels Sep 10, 2024
@jorenbroekema jorenbroekema self-assigned this Sep 10, 2024
@jorenbroekema jorenbroekema removed the triage To be reproduced as bug label Sep 10, 2024
@jorenbroekema jorenbroekema added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 1, 2024
@florin01hyma florin01hyma self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants