Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glossary page #7

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ChucKN0risK
Copy link
Collaborator

This PR adds a Glossary page as explained in this task.

@jorenbroekema could you add something for "Token space" and "Resolution request" in the glossary.md file please? I couldn't find anything meaningful to write for these definitions.

Thanks :)

@ChucKN0risK ChucKN0risK added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Nov 5, 2024
@ChucKN0risK ChucKN0risK self-assigned this Nov 5, 2024
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for resolver-spec failed.

Name Link
🔨 Latest commit 3ee17e8
🔍 Latest deploy log https://app.netlify.com/sites/resolver-spec/deploys/6758435b983fac0008e745e4


## Token space

TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is in reference to

The references to the tokens used in this styling are tied to a single addressable token space

I was referring to a single large token set that then forms the final set of tokens you can address with keys like

colors.foo.500

It essentially is your plate in your cooking analogy holding the final dish with items in it , though it refers to any set really with the tokens it holds and what is addressable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I'll add this to the glossary and add the plate analogy to another visual then :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅


## Resolution request

TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be the request for to get some final tokens , so its the ordering of the dish in your cooking analogy.

I mention in the docs that it would likely be async as the token sets files might need to be read from some storage before the actual processing can be done

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks. Do you think it's important enough to add this to the glossary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants