-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glossary page #7
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for resolver-spec failed.
|
|
||
## Token space | ||
|
||
TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is in reference to
The references to the tokens used in this styling are tied to a single addressable token space
I was referring to a single large token set that then forms the final set of tokens you can address with keys like
colors.foo.500
It essentially is your plate in your cooking analogy holding the final dish with items in it , though it refers to any set really with the tokens it holds and what is addressable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I'll add this to the glossary and add the plate analogy to another visual then :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✅
|
||
## Resolution request | ||
|
||
TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be the request for to get some final tokens , so its the ordering of the dish in your cooking analogy.
I mention in the docs that it would likely be async as the token sets files might need to be read from some storage before the actual processing can be done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks. Do you think it's important enough to add this to the glossary?
This PR adds a Glossary page as explained in this task.
@jorenbroekema could you add something for "Token space" and "Resolution request" in the
glossary.md
file please? I couldn't find anything meaningful to write for these definitions.Thanks :)