Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with missing classname #568

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix issue with missing classname #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-radios-love.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tokens-studio/graph-editor": patch
---

The editor was missing the require `graph-editor` className that is used to create CSS layers for correct injectio of css vars
2 changes: 1 addition & 1 deletion packages/graph-editor/src/data/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const version = '4.3.2';
export const version = '4.3.3';
7 changes: 5 additions & 2 deletions packages/graph-editor/src/editor/layoutController.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,14 +294,14 @@
//Generate once
const defaultDockLayout: LayoutData = useMemo(
() => layoutDataFactory(props, ref),
[],

Check warning on line 297 in packages/graph-editor/src/editor/layoutController.tsx

View workflow job for this annotation

GitHub Actions / Verify changes 

React Hook useMemo has missing dependencies: 'props' and 'ref'. Either include them or remove the dependency array
);

useEffect(() => {
if (dockerRef?.current && initialLayout) {
dockerRef.current?.loadLayout(initialLayout);
}
}, [dockerRef]);

Check warning on line 304 in packages/graph-editor/src/editor/layoutController.tsx

View workflow job for this annotation

GitHub Actions / Verify changes 

React Hook useEffect has a missing dependency: 'initialLayout'. Either include it or remove the dependency array

const onLayoutChange = (newLayout: LayoutBase) => {
//We need to find the graph tab container in the newlayout
Expand All @@ -311,12 +311,15 @@
//Get the active Id to find the currently selected graph
dispatch.graph.setCurrentPanel(graphContainer.activeId!);
}
// dispatch.
};

return (
<ExternalLoaderProvider externalLoader={externalLoader}>
<Stack direction="column" style={{ height: '100%' }}>
<Stack
className="graph-editor"
direction="column"
style={{ height: '100%' }}
>
{props.showMenu && <MenuBar menu={menuItems} />}
<Tooltip.Provider>
<DockLayout
Expand Down
Loading