Fix subtraction

[SorsOps]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: f618b2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@tokens-studio/graph-editor	Patch
@tokens-studio/graph-engine-ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Analysis

• 🎯 Main theme: Addition of a new 'Stringify' node and a fix for subtraction operation in the graph editor.
• 📝 PR summary: This PR introduces a new 'Stringify' node to the graph editor, allowing users to convert various data types to string. It also includes a fix for the subtraction operation, ensuring it handles edge cases correctly. The changes are spread across multiple files, including the addition of new components, updates to existing ones, and modifications to the types.
• 📌 Type of PR: Enhancement
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in multiple files and the addition of a new feature (Stringify node), which requires a good understanding of the existing codebase to review effectively.
• 🔒 Security concerns: No

PR Feedback

• 💡 General suggestions: The PR seems to be well-structured and the changes are logically grouped. However, it would be beneficial to add tests for the new 'Stringify' node to ensure its functionality and to catch any potential issues early. Additionally, it would be helpful to provide a description in the PR to give reviewers more context about the changes.

• 🤖 Code feedback:

  • relevant file: packages/graph-engine/src/nodes/math/subtract.ts
    suggestion: Consider using a more descriptive variable name instead of 'x' in the reduce function. This would improve code readability. [medium]
    relevant line: '+ return vals.reduce((acc, x) => acc - x.value, input.inputs[0].value);'

  • relevant file: packages/graph-engine/src/nodes/string/stringify.ts
    suggestion: The 'process' function could be simplified by using a dictionary mapping for type conversion instead of a switch-case statement. This would make the code more concise and easier to maintain. [medium]
    relevant line: '+export const process = (input) => {'

  • relevant file: packages/graph-editor/src/components/flow/nodes/string/stringify.tsx
    suggestion: It seems that the 'BasicNode' component could be made more reusable. Consider abstracting some of the common elements into a separate component or using higher-order components. [medium]
    relevant line: '+export const BasicNode = () => {'

  • relevant file: packages/graph-editor/src/components/flow/wrapper/node.tsx
    suggestion: The 'maxWidth' property is hardcoded to 500. Consider making this a prop or a configurable option to improve flexibility. [medium]
    relevant line: '+ <Stack css={{ maxWidth: 500 }} direction="column" gap={0} {...rest}>'

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.