Fixes an issue with loading not working , relaxes restriction on requ…

…iring an input nodes as part of execution via options (#594)

.changeset/large-peas-dance.md

@@ -0,0 +1,5 @@
+---
+"@tokens-studio/graph-engine": patch
+---
+
+Fixes an issue with loading not working , relaxes restriction on requiring an input nodes as part of execution via options

packages/graph-engine/src/graph/graph.ts

@@ -30,6 +30,11 @@ export type InputDefinition = {
 };
 
 export type GraphExecuteOptions = {
+	/**
+	 * Throws an error if the input/output nodes are not found
+	 */
+	strict?: boolean;
+
 	inputs?: Record<string, InputDefinition>;
 	/**
 	 * Whether to track and emit stats as part of the execution
@@ -149,6 +154,7 @@ export interface BatchExecution {
 const defaultGraphOpts: IGraph = {
 	annotations: {}
 };
+
 /**
  * This is our internal graph representation that we use to perform transformations on
  */
@@ -643,7 +649,7 @@ export class Graph {
 			const input = Object.values(this.nodes).find(
 				x => x.factory.type === 'studio.tokens.generic.input'
 			);
-			if (!input) {
+			if (opts?.strict && !input) {
 				throw new Error('No input node found');
 			}
 
@@ -659,7 +665,7 @@ export class Graph {
 				}
 
 				//Its possible that there is no input with the name
-				input.inputs[key]?.setValue(value.value, opts);
+				input?.inputs[key]?.setValue(value.value, opts);
 			});
 		}
 

packages/graph-engine/src/programmatic/node.ts

@@ -207,7 +207,7 @@ export class Node {
 	 * @param data
 	 */
 	async load(uri: string, data?: unknown) {
-		this._graph?.loadResource(uri, this, data);
+		return this._graph?.loadResource(uri, this, data);
 	}
 
 	get isRunning() {

packages/graph-engine/tests/suites/graph/execution.test.ts

@@ -0,0 +1,48 @@
+import { Graph } from '../../../src/graph/graph.js';
+import { Node, NumberSchema } from '../../../src/index.js';
+import { describe, expect, test } from 'vitest';
+
+class ExternalNode extends Node {
+	constructor(props) {
+		super(props);
+
+		this.addOutput('foo', { type: NumberSchema });
+	}
+
+	async execute() {
+		const val = await this.load('foo');
+		this.outputs.foo.set(val);
+	}
+}
+
+describe('Graph/execution', () => {
+	test('throws an error when the external loader can be caught', async () => {
+		const graph = new Graph();
+
+		new ExternalNode({ id: 'a', graph });
+
+		let thrown;
+		try {
+			await graph.execute();
+		} catch (err) {
+			thrown = err;
+		} finally {
+			expect(thrown).toBeDefined();
+			expect(thrown.message).toEqual('No external loader specified');
+		}
+	});
+
+	test('External loading works as expected', async () => {
+		const graph = new Graph();
+
+		graph.externalLoader = async () => {
+			return 5;
+		};
+
+		new ExternalNode({ id: 'a', graph });
+
+		await graph.execute();
+
+		expect(graph.nodes.a.outputs.foo.value).toEqual(5);
+	});
+});

packages/graph-engine/tests/suites/graph/opts.test.ts

@@ -0,0 +1,27 @@
+import { Graph } from '../../../src/graph/graph.js';
+import { describe, expect, test } from 'vitest';
+import Passthrough from '../../../src/nodes/generic/passthrough.js';
+
+describe('Graph/options', () => {
+	test('throws an error if strict mode is enabled', async () => {
+		const graph = new Graph();
+
+		new Passthrough({ id: 'a', graph });
+		let thrown;
+		try {
+			await graph.execute({
+				strict: true,
+				inputs: {
+					foo: {
+						value: 1
+					}
+				}
+			});
+		} catch (err) {
+			thrown = err;
+		} finally {
+			expect(thrown).toBeDefined();
+			expect(thrown.message).toEqual('No input node found');
+		}
+	});
+});