Allow dynamic inputs for array map subgraph

tokens-studio · May 16, 2024 · 1d19e79 · 1d19e79
1 parent 48ae1ac
commit 1d19e79
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/graph-engine/src/nodes/array/arraySubgraph.ts b/packages/graph-engine/src/nodes/array/arraySubgraph.ts
@@ -26,8 +26,7 @@ export default class ArraySubgraph<T, V> extends SubgraphNode {
 
     if (!input) throw new Error("No input node found in subgraph");
 
-
-    input.annotations['ui.editable'] = false;
+    input.annotations[annotatedDynamicInputs] = true;
 
     input.addInput("value", {
       type: AnySchema,
@@ -45,7 +44,6 @@ export default class ArraySubgraph<T, V> extends SubgraphNode {
       visible: false,
       annotations: {
         "ui.editable": false,
-        "ui.hidden": true,
         [hideFromParentSubgraph]: true
       }
     });

diff --git a/packages/graph-engine/src/nodes/generic/subgraph.ts b/packages/graph-engine/src/nodes/generic/subgraph.ts
@@ -46,7 +46,6 @@ export default class SubgraphNode extends Node {
 
       //Get the existing inputs 
       const existing = this.inputs;
-
       //Iterate through the inputs of the input node in the inner graph
       Object.entries(input.inputs).map(([key, value]) => {
 
@@ -61,16 +60,16 @@ export default class SubgraphNode extends Node {
             noPropagate: true
           });
         } else {
+          //Note its possible that the input key still does not exist due to an annotation ,etc 
           //Update the value 
-          this.inputs[key].setValue(value.value, {
+          this.inputs[key]?.setValue(value.value, {
             noPropagate: true
           });
         }
         //TODO handle deletions and mutations
       });
-
+      console.log('updating value')
       //Handle updates from the inner graph
-      this.setOutput("value", output.outputs.value.value, output.outputs.value.type);
     });
   }
 

diff --git a/packages/graph-engine/src/schemas/index.ts b/packages/graph-engine/src/schemas/index.ts
@@ -298,6 +298,9 @@ export const canConvertSchemaTypes = (
   if (src.type == "array" && target.$id == ANY_ARRAY) {
     return true;
   }
+  if (src.type == "array" && target.type == 'array') {
+    if (target.items?.$id === ANY) return true;
+  }
 
   switch (src.$id) {
     case COLOR: