Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatic support for token transformer #1514

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Conversation

SorsOps
Copy link
Member

@SorsOps SorsOps commented Jan 4, 2023

This exposes the transformTokens method to be used programmatically instead of having to only use the CLI approach. It also fixes a minor bug found with windows machines where the path seperator was treated differently causing tests to fail

Fixes #1259

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Commit SHA:158774237d89ae11cb317e1829df744024551de1
No changes to code coverage between the base branch and the head branch

@SorsOps SorsOps requested a review from six7 January 4, 2023 10:32
@six7 six7 merged commit df6361e into main Jan 5, 2023
six7 pushed a commit that referenced this pull request Jan 10, 2023
This exposes the transformTokens method to be used programmatically
instead of having to only use the CLI approach. It also fixes a minor
bug found with windows machines where the path seperator was treated
differently causing tests to fail

Fixes #1259

Co-authored-by: andrewx82 <[email protected]>
six7 pushed a commit that referenced this pull request Jan 13, 2023
This exposes the transformTokens method to be used programmatically
instead of having to only use the CLI approach. It also fixes a minor
bug found with windows machines where the path seperator was treated
differently causing tests to fail

Fixes #1259

Co-authored-by: andrewx82 <[email protected]>
six7 pushed a commit that referenced this pull request Jan 13, 2023
This exposes the transformTokens method to be used programmatically
instead of having to only use the CLI approach. It also fixes a minor
bug found with windows machines where the path seperator was treated
differently causing tests to fail

Fixes #1259

Co-authored-by: andrewx82 <[email protected]>
@SorsOps SorsOps deleted the feat/resolve-util-lib branch July 6, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

token-transformer: Code should use path.join() instead of manually concatenating a /
2 participants