Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #4

Closed
mottosso opened this issue Aug 1, 2017 · 7 comments
Closed

Tests #4

mottosso opened this issue Aug 1, 2017 · 7 comments

Comments

@mottosso
Copy link
Collaborator

mottosso commented Aug 1, 2017

Let's get AppVeyor and Travis into the game, with tests for Windows and Unix.

@tokejepsen
Copy link
Owner

Yeah, that sounds like a good idea :)

When do you think is a good time to start testing? Since the module is still under development, lots could change, even something like the arguments to the methods.

@mottosso
Copy link
Collaborator Author

mottosso commented Aug 1, 2017

I think now is a good time. If only to document and assert for ourselves things like #3 and flesh out all other edge cases and obscurities that we find as we develop. Ideally we'd submit PRs with just tests, and work out the implementation from there.

@tokejepsen
Copy link
Owner

How come we need both AppVeyor and Travis for tests?

@mottosso
Copy link
Collaborator Author

mottosso commented Aug 1, 2017

AppVeyor does Windows, Travis does Unix

@tokejepsen
Copy link
Owner

Ahh :)

What about the testing framework? You have more experience with them than I, but seems like nose2 might be a good choice?

@mottosso
Copy link
Collaborator Author

mottosso commented Aug 1, 2017

Up to you :) I tend to go with nose, but it's a personal choice. I've heard good things about py.test too.

@tokejepsen tokejepsen mentioned this issue Aug 1, 2017
tokejepsen added a commit that referenced this issue Aug 2, 2017
@tokejepsen
Copy link
Owner

The testing framework ended up being pytest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants