Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OR-1470] change wton to wnativetoken #93

Merged
merged 1 commit into from
Mar 18, 2024
Merged

[OR-1470] change wton to wnativetoken #93

merged 1 commit into from
Mar 18, 2024

Conversation

steven94kr
Copy link
Contributor

  • add deploy config (nativeTokenName, nativeTokenSymbol)
  • change wton to wnativetoken
  • add L1devnet in verify-scripts and fix typo and change version of compiler of WNativeToken

image

Thank you!

@steven94kr
Copy link
Contributor Author

@nguyenzung
I'm sorry. I accidentally did something else while I was working.
Legacy_ERC20_ETH -> Legacy_ERC20_{NativeTOkenName} will be processed in the next ticket. https://onther.atlassian.net/browse/OR-1415?atlOrigin=eyJpIjoiZGYwNjk3Mzc2YTg3NGQwYjgwODliNjM5NzBiMDU3NzAiLCJwIjoiaiJ9

nguyenzung
nguyenzung reviewed Mar 15, 2024
View reviewed changes
packages/tokamak/contracts-bedrock/scripts/Deploy.s.sol
@@ -145,7 +145,7 @@ contract Deploy is Deployer {
/// @notice Deploy the Safe
function deployL2NativeToken() public onlyDevnet broadcast {
address addr_ = getL2NativeToken();
cfg.setNativeTokenAddress(addr_);
cfg.setNativeTokenAddress(addr_, string.concat(vm.projectRoot(), "/deploy-config/", deploymentContext, ".json"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function only works for devnet with the modifier onlyDevnet. I think we maybe should update this function to work with deploymentContext.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I forgot to explain!
This function is to change the nativeTokenAddress of devnetl1.json to the actually distributed address. (Currently, the address set in the template goes to devnetL1.json.)
I think this should only work on devnet. 🙇🏼‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

I understood.

@nguyenzung nguyenzung self-requested a review March 15, 2024 09:46
nguyenzung
nguyenzung approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@nguyenzung nguyenzung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Steven 💯

@steven94kr steven94kr merged commit f1422a2 into OR-1257-Update-smart-contracts-for-deposit-TON-in-L1 Mar 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenzung nguyenzung nguyenzung approved these changes

@theo-learner theo-learner Awaiting requested review from theo-learner

@ohbyeongmin ohbyeongmin Awaiting requested review from ohbyeongmin

@AaronLee22 AaronLee22 Awaiting requested review from AaronLee22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steven94kr @nguyenzung