-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Or 1921 set deploy config thanos sepolia #297
Conversation
"faultGameMaxDepth": 73, | ||
"faultGameClockExtension": 10800, | ||
"faultGameMaxClockDuration": 302400, | ||
"faultGameGenesisBlock": , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need double quotential if there is no value!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right! I'll update the empty values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked that all packages is well built. But to be clear, can you define the range of the review? Please let us test method or something if you have it.
How about making the page for the fault proof deploy params? |
Thank you for the suggestion! I’ll create a dedicated page for the Fault Proof deploy parameters, |
https://docs.optimism.io/builders/chain-operators/configuration/rollup#fault-proofs |
Sorry I missed it. Thanks @steven94kr . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-run actions. It is weird... I think we can resolve the action later.
Thank you very much!
Set-deploy-config-thanos-sepolia for FPS
"faultGameAbsolutePrestate": "0x03ab262ce124af0d5d328e09bf886a2b272fe960138115ad8b94fdc3034e3155",
"faultGameMaxDepth": 73,
"faultGameClockExtension": 10800,
"faultGameMaxClockDuration": 302400,
"faultGameGenesisBlock": ,
"faultGameGenesisOutputRoot": "",
"faultGameSplitDepth": 30,
"faultGameWithdrawalDelay": 604800,
"preimageOracleMinProposalSize": 126000,
"preimageOracleChallengePeriod": 86400,
"proofMaturityDelaySeconds": 604800,
"disputeGameFinalityDelaySeconds": 302400,
"respectedGameType": 0,
"useFaultProofs": true,
Have to set before the upgrade
faultGameGenesisBlock: The block number at the time of applying FPS, before the upgrade.
faultGameGenesisOutputRoot: The hash of the block at the time of applying FPS, before the upgrade.