Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): update SDK after external audit #296

Merged
merged 4 commits into from
Oct 30, 2024
Merged

feat(sdk): update SDK after external audit #296

merged 4 commits into from
Oct 30, 2024

Conversation

0x6e616d
Copy link
Member

No description provided.

@0x6e616d 0x6e616d force-pushed the OR-1905-update-sdk-after-external-audit branch from 8b1954e to 41bcf34 Compare October 29, 2024 03:00
theo-learner
theo-learner reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@theo-learner theo-learner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I leaved comments in your code. And can you bump package version? We have already publish v0.0.9 to npm, but this version is v0.0.8.

packages/tokamak/sdk/src/portals.ts

public async waitingDepositTransactionRelayedUsingL1Tx(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check it? This function is used for deposit ERC20 and ETH in hardhat tasks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I updated

Copy link
Member Author

@0x6e616d 0x6e616d Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the version, I think after this PR, I will ping Steven to help me to pump the new version of SDK.
Let him manage the version of our libraries

@0x6e616d 0x6e616d force-pushed the OR-1905-update-sdk-after-external-audit branch 2 times, most recently from af1596e to 04bcb63 Compare October 29, 2024 05:01
@0x6e616d 0x6e616d force-pushed the OR-1905-update-sdk-after-external-audit branch from 04bcb63 to 4d99007 Compare October 30, 2024 08:24
@theo-learner
Copy link
Member

I have checked all tasks are working well. Thank you so much.
@steven94kr Do you have any suggestion for versioning of sdk package?

@steven94kr
Copy link
Contributor

@0x6e616d
What I was talking about last time was about the release tag. (I remember you push tag before)

I will attach the release tag and release it.

It is good to use the npm version when the code is modified. (Sometimes it's missing, haha)
It seems better to change it to 0.0.9.

Can you do this for me? 🙇🏻‍♂️

@0x6e616d
Copy link
Member Author

@0x6e616d What I was talking about last time was about the release tag. (I remember you push tag before)

I will attach the release tag and release it.

It is good to use the npm version when the code is modified. (Sometimes it's missing, haha) It seems better to change it to 0.0.9.

Can you do this for me? 🙇🏻‍♂️

I update two packages version:

  • @tokamak-network/sdk to v0.0.9
  • @tokamak-network/contract-utils to v0.0.2

@steven94kr
Copy link
Contributor

Thank you very much!
I think we can merge it!

@0x6e616d 0x6e616d merged commit ca19f32 into main Oct 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theo-learner theo-learner theo-learner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x6e616d @theo-learner @steven94kr