-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): doc level permission #9760
base: canary
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #9760 +/- ##
==========================================
- Coverage 53.54% 44.01% -9.53%
==========================================
Files 2280 2276 -4
Lines 103623 104551 +928
Branches 17182 16022 -1160
==========================================
- Hits 55480 46018 -9462
- Misses 46763 57190 +10427
+ Partials 1380 1343 -37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c42b7dc
to
ffd76bd
Compare
ffd76bd
to
a64a5c7
Compare
d3a2fd1
to
f7c3a2d
Compare
f0e5e23
to
e169b26
Compare
e169b26
to
207047a
Compare
3d1b149
to
3aa0297
Compare
|
||
export const Actions = { | ||
Workspace: { | ||
Sync: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the numbers meaning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It refers to the action index in ActionsKeys
. Generally, a higher number indicates a more advanced role is required.
role!: DocRole; | ||
|
||
@Field(() => RolePermissions) | ||
permissions!: RolePermissions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is strange. Workspace permissions will be returned in doc type. If separate them, we could even make code cleaner without 'Doc_' prefix
3aa0297
to
8d89c5c
Compare
6863843
to
0d7b125
Compare
0d7b125
to
3544036
Compare
close CLOUD-89 CLOUD-90 CLOUD-91 CLOUD-92