Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): linked doc named input box has excessive desire to select all #8861

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

akumatus
Copy link
Member

@akumatus akumatus commented Nov 19, 2024

Fix issue AF-1706.

Copy link

graphite-app bot commented Nov 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akumatus akumatus marked this pull request as ready for review November 19, 2024 04:16
@graphite-app graphite-app bot requested review from CatsJuice, forehalo, pengx17, JimmFly and EYHN and removed request for pengx17 and JimmFly November 19, 2024 04:16
Copy link

nx-cloud bot commented Nov 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b0ca3c6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.25%. Comparing base (4011062) to head (3b8d61b).

Files with missing lines Patch % Lines
...ages/frontend/component/src/ui/input/row-input.tsx 0.00% 7 Missing ⚠️
...s/frontend/component/src/hooks/focus-and-select.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8861   +/-   ##
=======================================
  Coverage   70.25%   70.25%           
=======================================
  Files         550      550           
  Lines       33980    33980           
  Branches     3052     3052           
=======================================
  Hits        23871    23871           
  Misses       9737     9737           
  Partials      372      372           
Flag Coverage Δ
server-test 77.14% <ø> (ø)
unittest 46.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

graphite-app bot commented Nov 20, 2024

Merge activity

@graphite-app graphite-app bot merged commit b0ca3c6 into canary Nov 20, 2024
47 checks passed
@graphite-app graphite-app bot deleted the fix/linked-doc-prompt-select branch November 20, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants