Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): wrong title field from editor container proxy #8826

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

forehalo
Copy link
Member

fix AF-1689

Copy link

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

forehalo commented Nov 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 54c5122. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.30%. Comparing base (991e0b9) to head (22a622a).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8826      +/-   ##
==========================================
- Coverage   70.30%   70.30%   -0.01%     
==========================================
  Files         550      550              
  Lines       33978    33978              
  Branches     3052     3052              
==========================================
- Hits        23889    23887       -2     
- Misses       9717     9719       +2     
  Partials      372      372              
Flag Coverage Δ
server-test 77.21% <ø> (ø)
unittest 46.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@forehalo forehalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimmFly 测试过不了,好像是受 scroll position 的逻辑影响了

Copy link
Member

JimmFly commented Nov 14, 2024

要不把这行删了吧,不要传 title 了,peek view 没有 focus title 的需求

Copy link

graphite-app bot commented Nov 15, 2024

Merge activity

@graphite-app graphite-app bot merged commit 54c5122 into canary Nov 15, 2024
47 checks passed
@graphite-app graphite-app bot deleted the 61/doc-peek-view branch November 15, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants