-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): wrong title field from editor container proxy #8826
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 54c5122. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8826 +/- ##
==========================================
- Coverage 70.30% 70.30% -0.01%
==========================================
Files 550 550
Lines 33978 33978
Branches 3052 3052
==========================================
- Hits 23889 23887 -2
- Misses 9717 9719 +2
Partials 372 372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d8bd216
to
22a622a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JimmFly 测试过不了,好像是受 scroll position 的逻辑影响了
要不把这行删了吧,不要传 title 了,peek view 没有 focus title 的需求 |
22a622a
to
51fadb5
Compare
Merge activity
|
51fadb5
to
54c5122
Compare
fix AF-1689