Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): refactor duplicate with ZipTransformer #8207

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Sep 11, 2024

No description provided.

Copy link
Member Author

JimmFly commented Sep 11, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 11, 2024

Copy link

graphite-app bot commented Sep 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (ed4bf2c) to head (e11d598).

Additional details and impacted files
@@                              Coverage Diff                               @@
##           jimmfly/0911/rafactor-use-doc-meta-helper    #8207       +/-   ##
==============================================================================
+ Coverage                                      53.47%   78.75%   +25.28%     
==============================================================================
  Files                                           1259      228     -1031     
  Lines                                          49457    25807    -23650     
  Branches                                        6007     1585     -4422     
==============================================================================
- Hits                                           26446    20324     -6122     
+ Misses                                         22968     5482    -17486     
+ Partials                                          43        1       -42     
Flag Coverage Δ
server-test 78.75% <ø> (-0.04%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0911/rafactor-dulicate branch from cb0ddf5 to aa2953c Compare September 11, 2024 17:52
@JimmFly JimmFly marked this pull request as ready for review September 11, 2024 17:53
@JimmFly JimmFly marked this pull request as draft September 12, 2024 03:16
@JimmFly JimmFly force-pushed the jimmfly/0911/rafactor-use-doc-meta-helper branch from 875c9ac to ed4bf2c Compare September 12, 2024 06:18
@JimmFly JimmFly force-pushed the jimmfly/0911/rafactor-dulicate branch from aa2953c to e11d598 Compare September 12, 2024 06:19
@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Sep 12, 2024
@JimmFly JimmFly closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant