Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changes #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add changes #2

wants to merge 7 commits into from

Conversation

shirosweets
Copy link

ngduc
ngduc requested changes May 9, 2021
View reviewed changes
Copy link
Contributor

@ngduc ngduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of good changes here.
Just a few minor comments. Thanks.

README.md Outdated Show resolved Hide resolved
Examples_TODO/TODO.md Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
Examples_TODO/TODO2.md Outdated Show resolved Hide resolved
@shirosweets
Copy link
Author

@ngduc Check now ^_^

ngduc
ngduc requested changes May 10, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README_ES.md
## Ver también
- [Extensión de Vscode: Kanban Board](https://marketplace.visualstudio.com/items?itemName=coddx.coddx-alpha&ssr=false)
- [Extensión de Vscode: Kanban](https://marketplace.visualstudio.com/items?itemName=mkloubert.vscode-kanban)
- [README EN](README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ES version.

TODO_examples/TODO2.md Outdated
- [x] Keep the existing `README.md` and duplicate it to `README_ES.md` for ES language (P1)
- [x] Set prority in `TODO2.md` (P2)
- [x] Change Optional in `TODO2.md` (P1)
- [x] Use **P3** to Optional (P2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the (P*) convention. Are the bracket () the best options? It's ok for now.

@shirosweets
Copy link
Author

@ngduc

ngduc
ngduc approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@ngduc ngduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@flamenco108
Copy link

Hello.
If "x" means that task is completed, so the column.
Like:

### Column incomplete [ ]
### Column completed [x]

Isn't that more simple than looking for "✓" sign?

@dwettstein
Copy link

dwettstein commented Sep 27, 2024 •
edited
Loading

I would suggest to set the priority as a first part, before the description.

See #7 for an example.

Edit: By the way, why is this not merged yet even though it's approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngduc ngduc ngduc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shirosweets @flamenco108 @dwettstein @ngduc