Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm and ruby dependencies #203

Closed
wants to merge 4 commits into from

Conversation

JeroenKnoops
Copy link
Contributor

Motivation

It's always good to keep the dependencies up-to-date.

Proposed Changes

  • Update dependencies in package.json. (added parse-domain, and fixed version for broken_link_checker).
  • Update dependency lock (package-lock.json) files for Npm
  • Update dependency lock (Gemfile.lock) files for Ruby

Test Plan

I've manually installed the same environment as used in the ci workflow file.
I've ran bundle exec npm test and all tests passed.

Worked together on this with @Brend-Smits

@JeroenKnoops JeroenKnoops requested a review from trevmex as a code owner March 16, 2021 08:17
@JeroenKnoops
Copy link
Contributor Author

I've created 5 different logical commits. I can rebase them if you rather see that.

@JeroenKnoops
Copy link
Contributor Author

I will check all failing checks.

@JeroenKnoops JeroenKnoops force-pushed the update-deps branch 2 times, most recently from 89d379b to 76cfa10 Compare March 16, 2021 09:04
@prototypicalpro
Copy link
Collaborator

I'm not sure if you can view the logs, so if not here is the relevant error:

home/runner/work/repolinter/repolinter/node_modules/url-relation/lib/index.js:37
	return evaluateValue(customOptions?.[optionName], ...args) ?? defaultOption;
	                                   ^

SyntaxError: Unexpected token .
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/runner/work/repolinter/repolinter/node_modules/broken-link-checker/lib-cjs/internal/Link.js:14:43)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/runner/work/repolinter/repolinter/node_modules/broken-link-checker/lib-cjs/public/HtmlChecker.js:14:13)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/runner/work/repolinter/repolinter/node_modules/broken-link-checker/lib-cjs/index.js:80:43)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/runner/work/repolinter/repolinter/rules/file-no-broken-links.js:4:25)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Suite.<anonymous> (/home/runner/work/repolinter/repolinter/tests/rules/file_no_broken_links_tests.js:13:31)
    at Object.create (/home/runner/work/repolinter/repolinter/node_modules/mocha/lib/interfaces/common.js:148:19)
    at context.describe.context.context (/home/runner/work/repolinter/repolinter/node_modules/mocha/lib/interfaces/bdd.js:42:27)
    at Suite.describe (/home/runner/work/repolinter/repolinter/tests/rules/file_no_broken_links_tests.js:11:3)
    at Object.create (/home/runner/work/repolinter/repolinter/node_modules/mocha/lib/interfaces/common.js:148:19)
    at context.describe.context.context (/home/runner/work/repolinter/repolinter/node_modules/mocha/lib/interfaces/bdd.js:42:27)
    at Object.<anonymous> (/home/runner/work/repolinter/repolinter/tests/rules/file_no_broken_links_tests.js:10:1)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.exports.requireOrImport (/home/runner/work/repolinter/repolinter/node_modules/mocha/lib/esm-utils.js:42:12)
    at Object.exports.loadFilesAsync (/home/runner/work/repolinter/repolinter/node_modules/mocha/lib/esm-utils.js:55:34)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at Function.Module.runMain (internal/modules/cjs/loader.js:834:11)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
npm ERR! Test failed.  See above for more details.

I think the error is with a dependency of my fork of broken-link-checker, which recently had one of it's dependencies updated to drop node 12 support. I need to reevaluate if that fork can just be replaced with the main package, but in the meantime I've updated it to fix the error so if you run npm update again it should work.

@JeroenKnoops
Copy link
Contributor Author

Not needed anymore. Already resolved in #205
Great work! 🥂

@JeroenKnoops JeroenKnoops deleted the update-deps branch September 8, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants