-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm and ruby dependencies #203
Conversation
I've created 5 different logical commits. I can rebase them if you rather see that. |
I will check all failing checks. |
89d379b
to
76cfa10
Compare
I'm not sure if you can view the logs, so if not here is the relevant error:
I think the error is with a dependency of my fork of |
Not needed anymore. Already resolved in #205 |
Motivation
It's always good to keep the dependencies up-to-date.
Proposed Changes
parse-domain
, and fixed version forbroken_link_checker
).Test Plan
I've manually installed the same environment as used in the ci workflow file.
I've ran
bundle exec npm test
and all tests passed.Worked together on this with @Brend-Smits