Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file-no-broken-links rule #192

Merged
merged 34 commits into from
Dec 17, 2020
Merged

Conversation

prototypicalpro
Copy link
Collaborator

@prototypicalpro prototypicalpro commented Dec 8, 2020

Hello! I'm back again with another largish PR.

This PR adds support for checking markup files for broken links using the file-no-broken-links rule. This rule is meant to help catch those times when linked file/website in the README got deleted, and the link was never updated. To quote the rules documentation:

Scans a set of markup files for broken links. Links are tested by first rendering the markup file to HTML using github-markup, then each <a> tag in the HTML is extracted and tested using broken-link-checker--as a result, this rule only supports checking markup formats supported by github-markup. Absolute URLs are checked using a HTTP request, and relative URLs are checked by accessing the file specified.

github-markup and its dependencies must be installed and available in PATH to use this rule.

In addition to adding this rule, I reworked the Dockerfile and Github Actions workflows to reflect the new dependency on github-markup, and updated both the npm and ruby dependencies to newer versions. None of my changes should break existing repolinter setups.

Since the dependency list for a fully-functional repolinter installation is now rather long, my next item of business is reworking repolinter-action to support licensee, linguist, and github-markup.

@willnorris willnorris merged commit 9f0f471 into todogroup:master Dec 17, 2020
@willnorris
Copy link
Member

well crap. I borked this pretty good by pushing to the wrong remote, which merged these changes and closed the PR as merged :-\ I'll continue discussion of rollback (if you want that) in #194

@willnorris willnorris mentioned this pull request Dec 17, 2020
@github-actions
Copy link

🎉 This PR is included in version 0.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants