Evaluate and refine conversions between Register, ErrorCode, and ReturnVariant.
#328
Assignees
Comments
bors bot
added a commit
that referenced
this issue
Sep 13, 2021
329: Implement Subscribe in `libtock_unittest::fake::Kernel`. r=jrvanwhy a=jrvanwhy Like #326 , this does not have a full unit test suite because it was getting too large. Instead, I'll be adding the unit tests that need additional infrastructure (a `fake::Driver`) later, and have a TODO to remind myself. I added some conversions between `Register`, `ErrorCode`, and `ReturnVariant`. I'm not sure what these conversions should look like (some of the code is kind of awkward), so I opened #328 to take another look in the future. Co-authored-by: Johnathan Van Why <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The unit tests and system call implementations have some awkward conversions between
Registerand theErrorCodeandReturnVarianttypes. In particular, callingassert_eq!()on the results of a system call can be very awkward, as the type inference doesn't play well with theIntoandPartialEqinvocations involved.After all the system calls are implemented in
libtock_unittestandlibtock_platform, I will do a survey of conversions to and fromRegisterand see if I can refine them to make the code cleaner. This issue is to remind me to do that.The text was updated successfully, but these errors were encountered: