Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package.json): bump rxjs to rc4, remove chai types #1

Merged
merged 1 commit into from
Nov 20, 2016

Conversation

jayphelps
Copy link
Contributor

rc4 fixed the ReactiveX/rxjs#2112 so the chai types are no longer needed.

rc4 had other very minor changes: https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#500-rc4-2016-11-19

Bug Fixes

@tobymurray
Copy link
Owner

Whoops! Didn't mean to drag you into this personal project @jayphelps - didn't realize GitHub picked up the issue references from commits. Just wanted to leave myself a note to pick up the fix when it was available. Thanks so much for taking the time, I appreciate it!

@tobymurray tobymurray merged commit a14972c into tobymurray:master Nov 20, 2016
@jayphelps
Copy link
Contributor Author

jayphelps commented Nov 20, 2016

you certainly didn't drag me in. As a courtesy I was following up with every project I could find that had to work around the issue 🎉 I was snooping :o)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants