Allow for purchasing the cheapest private if it has no bids #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add parenthesis to keep styling consistent? other than that looks good |
|
Ah! I misunderstand a rubocop warning and removed them. They should be back now. |
tobymao
approved these changes
Mar 12, 2020
crericha
referenced
this pull request
in crericha/18xx
Nov 3, 2020
…needs to be plumbed into UI. Acquire coal marker from VA tunnel and restrict VA tunnel lay to tile #4.
tobymao
pushed a commit
that referenced
this pull request
Nov 11, 2020
* Virginia coalfields can't be tokened. * More coal marker functionality. Add logic to buy coal markers. Still needs to be plumbed into UI. Acquire coal marker from VA tunnel and restrict VA tunnel lay to tile #4. * Make va coalfields hex block unless corporation has a coal marker. * Minor clean-up. * Implement buying coal markers. * Remove VA coalfields from ability description. Clear graph after buying a coal marker. * Add tests for coalfields functionality. * Run rubocop. * Prefer modifying the va coalfields city instance to add blocking behavior. * Convert item from hash to object.
crericha
added a commit
that referenced
this pull request
Jul 15, 2022
* events, loans, market boe impl * fix 8060 * [18USA] Golden parachute doesn't pay out if corp owned by market * block variable changed to sp * implement private abilities * fix boe starting loan * fix rubocop changes Co-authored-by: bena <[email protected]> Co-authored-by: Chris Rericha <[email protected]>
daniel-sousa-me
pushed a commit
to daniel-sousa-me/18xx
that referenced
this pull request
Aug 16, 2022
* events, loans, market boe impl * fix 8060 * [18USA] Golden parachute doesn't pay out if corp owned by market * block variable changed to sp * implement private abilities * fix boe starting loan * fix rubocop changes Co-authored-by: bena <[email protected]> Co-authored-by: Chris Rericha <[email protected]>
tobymao
pushed a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, you can bid on the cheapest private rather than buy it outright. The existing bid action is already designed to let you purchase the private in that situation, so this change is really just changing the way the action gets rendered.