Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rules for 1860 and 18Ireland to deprecate my personal dropbox #11309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update rules for 1860 and 18Ireland to deprecate my personal dropbox #11309

wants to merge 2 commits into from

Conversation

benjaminxscott
Copy link
Collaborator

Before clicking "Create"

  • Branch is derived from the latest master
  • [NA] Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Update direct rules links for 1860 and 18Ireland to point to BGG instead of my personal dropbox (reduce bus factor and fragility)

Screenshots

Any Assumptions / Hacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roseundy roseundy roseundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminxscott @roseundy