Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18Uruguay] Attempt to solve the dividend_types bug #11213

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

patrikolesen
Copy link
Contributor

Fixes #11141
Fixes #11194

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Screenshots

Any Assumptions / Hacks

@patrikolesen
Copy link
Contributor Author

patrikolesen commented Sep 12, 2024

Not sure that this actually solves the issue but it looked incorrect

Copy link
Collaborator

@ollybh ollybh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got no idea if this will fix these bugs, but the change is fine.

@ollybh ollybh merged commit fdc100c into tobymao:master Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[18Uruguay] Game doesn't open 18Uruguay - game not loading
2 participants