Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18Uruguay] Allow more than 60% to cover for loans #11212

Merged
merged 2 commits into from
Oct 7, 2024
Merged

[18Uruguay] Allow more than 60% to cover for loans #11212

merged 2 commits into from
Oct 7, 2024

Conversation

patrikolesen
Copy link
Contributor

Fixes #11110

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Screenshots

Any Assumptions / Hacks

ollybh
ollybh requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@ollybh ollybh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look at making this change by overriding the can_gain? method?

lib/engine/game/g_18_uruguay/step/buy_sell_par_shares.rb Outdated Show resolved Hide resolved
lib/engine/game/g_18_uruguay/step/buy_sell_par_shares.rb Outdated Show resolved Hide resolved
@ollybh ollybh added archive_alpha_games Needs alpha games archiving 18Uruguay labels Sep 19, 2024
@ollybh ollybh merged commit 3f9b8ab into tobymao:master Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollybh ollybh ollybh approved these changes

Assignees
No one assigned
Labels
18Uruguay archive_alpha_games Needs alpha games archiving
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[18Uruguay] - Cannot buy 7th share of a company that's over the Loan Limit
2 participants
@patrikolesen @ollybh