[18SJ] Corrects edge case nationalization calculation

[philcampeau]

Before clicking "Create"

• Branch is derived from the latest master
• Add the pins or archive_alpha_games label if this change will break existing games
• Code passes linter with docker compose exec rack rubocop -a
• Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Currently, the nationalization method uses this code to determine which corp of the eligible candidates will be nationalized:

          merged = candidates.max_by { |c| [c.share_price.price, [email protected]_index(c)] }

The problem is that the second sorting criteria uses the initial round order, meaning that if one corp runs and withholds, and moves into the same space as another corp, and they then are both eligible for nationalization, the corp that withheld will be nationalized, even though its token is under the other corp. This issue was reported on boardgamegeek here: https://boardgamegeek.com/thread/3366312/nationalisation-the-first-corporation-in-descendin

I've replaced this with the sorting used by def sort_order_key in lib/engine/corporation.rb:

          merged = candidates.max_by do |c|
            [c.share_price.price, -c.share_price.coordinates.last, -c.share_price.coordinates.first]
          end

which produces the desired result.

This will require pins for any games that have done the wrong nationalization, of course.

Screenshots

Any Assumptions / Hacks

[perwestling]

Looks good.