Skip to content

Commit

Permalink
fix(start): issue with metro not automatically starting fixed in RN CLI
Browse files Browse the repository at this point in the history
release-npm
  • Loading branch information
tobua committed Dec 18, 2023
1 parent e72408f commit affdfba
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion documentation/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ To release a React Native app for Android a few manual steps are currently requi
sudo keytool -genkey -v -keystore my-upload-key.keystore -alias my-key-alias -keyalg RSA -keysize 2048 -validity 10000
```

Add the generated file to `/android/app/my-upload-key.keystore`, no need to commit this file as it will be integrated into the patch (it's fairly short). Once that's also done add the password you just entered as well as the file location to the end of `/android/gradle.properties`:
Add the generated file to `/android/app/my-upload-key.keystore`, this file is sensitive, will be gitignored and not appear in the patch, make sure to **back it up** somewhere safe (app can no longer be released if this key is lost!). Once that's also done add the password you just entered as well as the file location to the end of `/android/gradle.properties`:

```sh

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"logua": "^3.0.3",
"pakag": "^3.1.1",
"parse-gitignore": "^2.0.0",
"prettier": "^3.1.0",
"prettier": "^3.1.1",
"prompts": "^2.4.2",
"semver": "^7.5.4",
"semver-sort": "^1.0.0",
Expand All @@ -55,8 +55,8 @@
"@types/semver": "^7.5.6",
"jest-fixture": "^4.1.0",
"padua": "^2.0.7",
"react-native": "^0.73.0",
"vitest": "^1.0.2"
"react-native": "^0.73.1",
"vitest": "^1.0.4"
},
"peerDependencies": {
"react-native": ">= 0.73"
Expand Down
3 changes: 1 addition & 2 deletions script/android.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,5 @@ export const android = async (inputs: RunInputs) => {
execSync(`react-native run-android${runInputArguments} ${additionalCliArguments()}`, {
stdio: 'inherit',
})
log('Build done, opening app and starting bundler..')
execSync('react-native start', { stdio: 'inherit' })
log('Build done')
}
3 changes: 1 addition & 2 deletions script/ios.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,5 @@ export const ios = async (inputs: RunInputs) => {
execSync(`react-native run-ios${runInputArguments} ${additionalCliArguments()}`, {
stdio: 'inherit',
})
log('Build done, opening app and starting bundler..')
execSync('react-native start', { stdio: 'inherit' })
log('Build done')
}

1 comment on commit affdfba

@vercel
Copy link

@vercel vercel bot commented on affdfba Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

numic – ./

numic.vercel.app
numic-git-main-tobua.vercel.app
numic-tobua.vercel.app

Please sign in to comment.