Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser-specs script for IETF drafts #768

Merged
merged 1 commit into from
Dec 5, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/browser-specs.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,18 @@ request({
.filter(function(spec) {
// Only keep specs from browser-specs that meet the following
// criteria:
// 1. The info comes from the spec itself. Other specs should
// already be in Specref.
// 1. The info comes from the spec itself or is an IETF draft.
// Other specs should already be in Specref.
// 2. The name ID is available, or lives in browser-specs.json.
// Given the way that browser-specs is maintained, a name collision
// means that the spec already started to appear in another source
// but this transition has not yet been picked up by browser-specs.
// That's good, no need to throw an error, let's give priority to
// the other source.
const uppercaseId = spec.shortname.toUpperCase();
return spec.source === 'spec' && !isInSpecref(uppercaseId);
return (spec.source === 'spec' ||
(spec.source === 'ietf' && !spec.url.match(/www\.rfc-editor\.org/))) &&
!isInSpecref(uppercaseId);
})
.forEach(function(spec) {
// Add an entry to browser-specs.json for the spec, unless Specref
Expand Down
Loading