Update README to clarify commit rights and review policy #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 from me, @tobie . I think it provides clear guidelines. I wonder whether (following the conversation in #459) a note / caveat should be added about adding entries from organisations (as W3C and IETF) that are feeding SpecRef directly. In such cases, it could be required that the corresponding PRs must be reviewed and/or must be only merged by the SpecRef editors. |
marcoscaceres
approved these changes
Apr 26, 2018
There was a problem hiding this comment.
This is great, @tobie. Thanks!
As an aside, would there be an value in putting this into a CONTRIBUTING.md instead?
Yeah, realized there wasn't one right after sending this pull request. Tracking here: #461. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @marcoscaceres
@andrea-perego, would love your thoughts on whether that gives the right amount of context for you to make the right decisions.