Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO7812-1 #387

Merged
merged 3 commits into from
Sep 20, 2017
Merged

Add ISO7812-1 #387

merged 3 commits into from
Sep 20, 2017

Conversation

marcoscaceres
Copy link
Collaborator

@marcoscaceres marcoscaceres commented Sep 20, 2017

Used by payments wg

@marcoscaceres marcoscaceres requested a review from tobie September 20, 2017 04:36
@marcoscaceres
Copy link
Collaborator Author

we should eventually make a "iso.json" file.... biblio.json is becoming quite the chunky monkey.

Copy link
Contributor

@dr-shorthair dr-shorthair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "isoNumber" rather than "status" to record the ISO standard number.

@marcoscaceres
Copy link
Collaborator Author

Didn't know that was a thing! Thanks.

@dr-shorthair
Copy link
Contributor

Yes - that is the plan. I added "isoNumber" last week to the schema in anticipation. And then we would need scripts/iso.js to handle it - but that is beyond my skillset I'm afraid.

@marcoscaceres
Copy link
Collaborator Author

scripts/iso.js to handle it - but that is beyond my skillset I'm afraid.

What would it do? Maybe I can help?

@tobie
Copy link
Owner

tobie commented Sep 20, 2017

Didn't know that was a thing! Thanks.

It's not reflected in the API for now, FYI. Would this be something you'd want to expose in ReSpec?

@marcoscaceres
Copy link
Collaborator Author

Depends... I don't yet understand the value of it over "status". What would be the benefit to readers over what they get today? This is really a question for @dr-shorthair

@marcoscaceres
Copy link
Collaborator Author

Btw, can we merge this and then do all the ISO specs at once? I'm keen to get the spec that needs this out the door. Then I can also go back to focusing on improving ReSpec.

@tobie
Copy link
Owner

tobie commented Sep 20, 2017

Sure, just please fix the status and we're good.

@marcoscaceres
Copy link
Collaborator Author

So, as ReSpec doesn't support isoNumber yet, I added both status and isoNumber... otherwise, there would be a gap when displaying the reference (because it would lack a status).

@tobie
Copy link
Owner

tobie commented Sep 20, 2017

Feel free to merge once green

@tobie tobie merged commit 558cfe2 into tobie:master Sep 20, 2017
@marcoscaceres marcoscaceres deleted the iso_cards branch September 21, 2017 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants