Update requirements to require scikit-learn and purge old requirements

[freemansw1]

Resolves #119 and #196.

Specific actions

• Removes pytables and cf-units from our dependencies (both are used by our dependencies, but not by us directly)
• Renames conda-requirements.txt to requirements.txt as that seems to be the standard (I cannot find reference to conda-requirements.txt anywhere)
• Adds requirements to setup.py such that pip install . installs dependencies as well.

Standard questions

• Have you followed our guidelines in CONTRIBUTING.md?
• Have you self-reviewed your code and corrected any misspellings?
• Have you written documentation that is easy to understand?
• Have you written descriptive commit messages?
• Have you added NumPy docstrings for newly added functions?
• Have you formatted your code using black?
• If you have introduced a new functionality, have you added adequate unit tests?
• Have all tests passed in your local clone?
• If you have introduced a new functionality, have you added an example notebook?
• Have you kept your pull request small and limited so that it is easy to review?
• Have the newest changes from this branch been merged?

[codecov]

Codecov Report

Base: 41.01% // Head: 41.01% // No change to project coverage 👍

Coverage data is based on head (aded93d) compared to base (e9cfd86).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           RC_v1.5.0     #204   +/-   ##
==========================================
  Coverage      41.01%   41.01%           
==========================================
  Files             14       14           
  Lines           2321     2321           
==========================================
  Hits             952      952           
  Misses          1369     1369           

Flag	Coverage Δ
unittests	41.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[freemansw1]

Note that the requirements in setup.py do not match those in requirements.txt because cartopy builds through pip appear to be broken, and our black runner depends on pip install . working. Removing cartopy is probably obvious, but this also required removing iris, because iris depends on cartopy.

[snilsn]

Good job @freemansw1, makes sense to me. There is a minor issue that I have found.

The README.md still references the old name of requirements.txt:

conda install -c conda-forge --yes --file conda-requirements.txt

[freemansw1]

Good catch! I've updated this.

[snilsn]

Great! Approving this now

[JuliaKukulies]

Great update @freemansw1!

[JuliaKukulies]

All right, approved!

And sorry that I missed your very clear comment on cartopy and iris! You are probably right that we can not do much about that.

[freemansw1]

All right, approved!

And sorry that I missed your very clear comment on cartopy and iris! You are probably right that we can not do much about that.

No worries! It is a bit odd, and I do worry that this will cause us headaches when putting things onto PyPI (#192), but it's the solution that we have for now.

[freemansw1]

I had to resolve a merge conflict with #191 merged in. @JuliaKukulies or @snilsn can you give this a quick look-over again and then I will merge?

[snilsn]

Looks good and ready to be merged @freemansw1!

[freemansw1]

Thanks!