Fixed RotatingFileHandler permission error (for Docker Toolbox on Win…

…dows) (hitachienergy#614)
to-bar · Oct 17, 2019 · 8acc67b · 8acc67b
1 parent e4f8e10
commit 8acc67b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG-0.4.md b/CHANGELOG-0.4.md
@@ -5,6 +5,7 @@
 ### Fixed
 
 - [#613](https://github.com/epiphany-platform/epiphany/pull/613) - Hotfixes for Ubuntu offline installation in air-gap mode
+- [#614](https://github.com/epiphany-platform/epiphany/pull/614) - Fixed RotatingFileHandler permission error (for Docker Toolbox on Windows)
 
 ## [0.4.0] 2019-10-11
 

diff --git a/core/src/epicli/cli/helpers/Log.py b/core/src/epicli/cli/helpers/Log.py
@@ -17,14 +17,14 @@ def __init__(self):
             log_path = os.path.join(get_output_path(), config.log_file)
             logging.basicConfig(level=logging.INFO, format=config.log_format, datefmt=config.log_date_format)
             formatter = jsonlogger.JsonFormatter(config.log_format, datefmt=config.log_date_format)
-            self.json_file_handler = logging.FileHandler(filename=log_path)
-            self.json_file_handler.setFormatter(formatter)
-            self.json_stream_handler = logging.StreamHandler()
-            self.json_stream_handler.setFormatter(formatter)
             should_roll_over = os.path.isfile(log_path)
-            handler = logging.handlers.RotatingFileHandler(log_path, mode='w', backupCount=config.log_count)
+            handler = logging.handlers.RotatingFileHandler(log_path, backupCount=config.log_count)
             if should_roll_over:
                 handler.doRollover()
+            self.json_file_handler = handler
+            self.json_file_handler.setFormatter(formatter)
+            self.json_stream_handler = logging.StreamHandler()
+            self.json_stream_handler.setFormatter(formatter)
 
     instance = None